diff options
| author | Jim Meyering <meyering@redhat.com> | 2008-03-19 13:37:04 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2008-03-19 13:38:27 +0100 |
| commit | 63feb84a2db5246fb71df45884589b914679110c (patch) | |
| tree | 445766ed937dd76bb685a3555cc44136ac1e6f7a /NEWS | |
| parent | 4b544e447eb78fd1f031a026a499f6aed177808a (diff) | |
| download | coreutils-63feb84a2db5246fb71df45884589b914679110c.tar.xz | |
mv: never unlink a destination file before calling rename
While cp --preserve=links must unlink certain destination files,
mv must never do that.
* src/copy.c (copy_internal): Pull the '! x->move_mode' test "up",
so it affects the entire condition, and not just DEREF_NEVER mode.
Reported by James Ralston in <http://bugzilla.redhat.com/438076>.
* tests/mv/atomic2: New file. Test for the above fix.
* tests/mv/Makefile.am (TESTS): Add atomic2.
* NEWS: Mention the bug-fix.
[Bug introduced in 367719ba5f1dbd5e2f7fa2466c441f23f66a7c9e]
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -12,6 +12,10 @@ GNU coreutils NEWS -*- outline -*- ls no longer segfaults on files in /proc when linked with an older version of libselinux. E.g., ls -l /proc/sys would dereference a NULL pointer. + mv would mistakenly unlink a destination file before calling rename, + when the destination had two or more hard links. It no longer does that. + [bug introduced in coreutils-5.3.0] + "rmdir --ignore-fail-on-non-empty" detects and ignores the failure in more cases when a directory is empty. |