diff options
| author | Pádraig Brady <P@draigBrady.com> | 2012-09-16 04:10:50 +0100 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2012-09-16 11:41:50 +0100 |
| commit | a04ddb8dd3fffd3457f927a36f6840fc1465aba2 (patch) | |
| tree | a62d215ecd1b67d6a6daf9c5c025252c80fa2f98 /NEWS | |
| parent | c5ccf29bbfaab01ed893c9ca3a3843181c329317 (diff) | |
| download | coreutils-a04ddb8dd3fffd3457f927a36f6840fc1465aba2.tar.xz | |
ls: fix coloring of dangling symlinks in default listing mode
When listing a directory containing dangling symlinks,
and not outputting a long format listing, and orphaned links
are set to no coloring in LS_COLORS, then the symlinks
would get no color rather than reverting to the standard
symlink color. The issue was introduced in v8.13-19-g84457c4
* src/ls.c (print_color_indicator): Use the standard method
to check if coloring is specified for orphaned symlinks.
The existing method would consider 'or=00' or 'or=0' as significant
in LS_COLORS. Even 'or=' was significant as in that case the
string='or=' and the length=0. Also apply the same change
for missing symlinks for consistency.
(gobble_file): Remove the simulation of linkok, which is only
tested in print_color_indicator() which now handles this directly
by keying on the LS_COLORS values correctly.
* tests/misc/ls-misc.pl: Add a test case.
* THANKS: Add the reporter.
* NEWS: Mention the fix.
Reported-by: David Matei
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -21,6 +21,10 @@ GNU coreutils NEWS -*- outline -*- numbers, and up to 8 times slower for some worst-case individual numbers. [bug introduced in coreutils-7.0, with GNU MP support] + ls now correctly colors dangling symlinks when listing their containing + directories, with orphaned symlink coloring disabled in LS_COLORS. + [bug introduced in coreutils-8.14] + rm -i -d now prompts the user then removes an empty directory, rather than ignoring the -d option and failing with an 'Is a directory' error. [bug introduced in coreutils-8.19, with the addition of --dir (-d)] |