diff options
| author | Jim Meyering <jim@meyering.net> | 2007-06-23 10:11:25 +0200 |
|---|---|---|
| committer | Jim Meyering <jim@meyering.net> | 2007-06-23 10:11:25 +0200 |
| commit | 519d7a95a3f8103925aa84f9bdef326ce88d37cc (patch) | |
| tree | c4a82988e9651e115fa1c2cccc6227cb136de4fa /Makefile.maint | |
| parent | a0304574e96916f0444b04f301f8e5191615f800 (diff) | |
| download | coreutils-519d7a95a3f8103925aa84f9bdef326ce88d37cc.tar.xz | |
Prefer "STREQ (a, b)" over "strcmp (a, b) == 0"; similar for != 0.
* src/base64.c (main): Likewise.
* src/install.c (setdefaultfilecon): Likewise.
* src/sort.c (main): Likewise.
* Makefile.maint (sc_prohibit_strcmp): New rule.
* .x-sc_prohibit_strcmp: New file, to list the few exceptions.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp.
Diffstat (limited to 'Makefile.maint')
| -rw-r--r-- | Makefile.maint | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Makefile.maint b/Makefile.maint index bb666a4ad..04efbc297 100644 --- a/Makefile.maint +++ b/Makefile.maint @@ -125,6 +125,13 @@ sc_prohibit_atoi_atof: { echo '$(ME): do not use *scan''f, ato''f, ato''i, ato''l, ato''ll, ato''q, or ss''canf' \ 1>&2; exit 1; } || : +# Use STREQ rather than comparing strcmp == 0, or != 0. +sc_prohibit_strcmp: + @grep -nE '! *str''cmp \(|\<str''cmp \([^)]+\) *==' \ + $$($(CVS_LIST_EXCEPT)) && \ + { echo '$(ME): use STREQ in place of the above uses of str''cmp' \ + 1>&2; exit 1; } || : + # Using EXIT_SUCCESS as the first argument to error is misleading, # since when that parameter is 0, error does not exit. Use `0' instead. sc_error_exit_success: |