diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2006-12-13 22:03:54 +0100 |
|---|---|---|
| committer | Jim Meyering <jim@meyering.net> | 2006-12-13 22:03:54 +0100 |
| commit | ec95137cc376119f634610a7683a296fc7b78ea4 (patch) | |
| tree | 52d315f085e18022db44722d7e58f3e4635d84d9 /ChangeLog | |
| parent | ae3ee95eb8372ec5947e3c790c6ea77bc703c160 (diff) | |
| download | coreutils-ec95137cc376119f634610a7683a296fc7b78ea4.tar.xz | |
Remove some arbitrary restrictions on size fields,
so that commands like "sort -k 18446744073709551616" no longer fail merely
because 18446744073709551616 doesn't fit in uintmax_t. The trick is that
these fields can all be treated as effectively infinity; their exact
values don't matter, since no internal buffer can be that long.
* src/join.c (string_to_join_field): Verify that SIZE_MAX <= ULONG_MAX
if the code assumes this. Silently truncate too-large values to SIZE_MAX,
as the remaining code will do the right thing in this case.
* src/sort.c (parse_field_count): Likewise.
* src/uniq.c (size_opt, main): Likewise.
* tests/join/Test.pm (bigfield): New test.
* tests/sort/Test.pm (bigfield): New test.
* tests/uniq/Test.pm (121): New test.
Signed-off-by: Jim Meyering <jim@meyering.net>
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 18 |
1 files changed, 18 insertions, 0 deletions
@@ -1,3 +1,21 @@ +2006-12-13 Paul Eggert <eggert@cs.ucla.edu> + + Remove some arbitrary restrictions on size fields, so that + commands like "sort -k 18446744073709551616" no longer fail merely + because 18446744073709551616 doesn't fit in uintmax_t. The trick + is that these fields can all be treated as effectively infinity; + their exact values don't matter, since no internal buffer can be + that long. + * src/join.c (string_to_join_field): Verify that SIZE_MAX <= + ULONG_MAX if the code assumes this. Silently truncate too-large + values to SIZE_MAX, as the remaining code will do the right thing + in this case. + * src/sort.c (parse_field_count): Likewise. + * src/uniq.c (size_opt, main): Likewise. + * tests/join/Test.pm (bigfield): New test. + * tests/sort/Test.pm (bigfield): New test. + * tests/uniq/Test.pm (121): New test. + 2006-12-13 Jim Meyering <jim@meyering.net> * tests/chgrp/default-no-deref: New test. |