diff options
| author | Jim Meyering <jim@meyering.net> | 2006-10-13 21:11:53 +0000 |
|---|---|---|
| committer | Jim Meyering <jim@meyering.net> | 2006-10-13 21:11:53 +0000 |
| commit | 965232b5b9899e1939029c448d3870d92f35d1db (patch) | |
| tree | 5eb77136a45586ce600f9d93c0b51e1e17260f8c /ChangeLog | |
| parent | 5dea5d07cdad67d8ca1ce90eef9dc7847c057c02 (diff) | |
| download | coreutils-965232b5b9899e1939029c448d3870d92f35d1db.tar.xz | |
More chown/chgrp dereferencing-related fixes.
* src/chown-core.c (change_file_owner): Don't use fts_statp if
we're dereferencing symlinks.
Reverse conjuncts, so that we use dereference file_stats
(aka ent->fts_statp) only *after* we've confirmed that
chopt->affect_symlink_referent is true. Otherwise, we might
use ent->fts_statp uninitialized.
Don't turn on FTS_NOSTAT when dereferencing symlinks.
* tests/chown/deref: Update the expected diagnostic, now that
this test case (trying to use "chown --dereference ..." on a
dangling symlink) takes a different code path.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
@@ -1,3 +1,17 @@ +2006-10-13 Jim Meyering <jim@meyering.net> + + More chown/chgrp dereferencing-related fixes. + * src/chown-core.c (change_file_owner): Don't use fts_statp if + we're dereferencing symlinks. + Reverse conjuncts, so that we use dereference file_stats + (aka ent->fts_statp) only *after* we've confirmed that + chopt->affect_symlink_referent is true. Otherwise, we might + use ent->fts_statp uninitialized. + Don't turn on FTS_NOSTAT when dereferencing symlinks. + * tests/chown/deref: Update the expected diagnostic, now that + this test case (trying to use "chown --dereference ..." on a + dangling symlink) takes a different code path. + 2006-10-13 Paul Eggert <eggert@cs.ucla.edu> Sync from Bison, as follows: |