rm could malfunction under unusual circumstances:

When operating on a relative name longer than 511 bytes,
and (when either processing a directory that is neither writable
nor readable (but still searchable) or when determining whether
to prompt), and encountering an ENOMEM error while forming the
file name, rm would operate on a truncated-to-511-byte name
starting with "[...]" rather than the intended one.
* NEWS: Describe the bugs.
* src/remove.c: Correct two misuses of full_filename:
(full_filename0, xfull_filename): New functions.
(full_filename_): Rewrite to use full_filename0.
(AD_pop_and_chdir): Use xfull_filename, not full_filename.
(write_protected_non_symlink): Likewise.

1 files changed, 16 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index 1c3b257b0..eb8763a02 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2007-10-08  Jim Meyering  <meyering@redhat.com>
+
+	rm could malfunction under unusual circumstances:
+	When operating on a relative name longer than 511 bytes,
+	and (when either processing a directory that is neither writable
+	nor readable (but still searchable) or when determining whether
+	to prompt), and encountering an ENOMEM error while forming the
+	file name, rm would operate on a truncated-to-511-byte name
+	starting with "[...]" rather than the intended one.
+	* NEWS: Describe the bugs.
+	* src/remove.c: Correct two misuses of full_filename:
+	(full_filename0, xfull_filename): New functions.
+	(full_filename_): Rewrite to use full_filename0.
+	(AD_pop_and_chdir): Use xfull_filename, not full_filename.
+	(write_protected_non_symlink): Likewise.
+
 2007-10-07  Jim Meyering  <meyering@redhat.com>
 
 	Don't let a helper function modify errno.