summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2008-04-30 22:50:02 +0200
committerJim Meyering <meyering@redhat.com>2008-04-30 23:29:10 +0200
commite3171c43ebad36ca0746bc625607f87269ff4e73 (patch)
tree1fcb31d420e68aed3151a46ebf53a742c122a158
parentbbc49eb5368f9f19b66562210a4eb60ff5cfe153 (diff)
downloadcoreutils-e3171c43ebad36ca0746bc625607f87269ff4e73.tar.xz
tests: avoid spurious "make check-root" failure
* README (Running tests as root): Also set PATH in suggested "sudo" command. This avoids failure of at least tests/cp/cp-a-selinux when the default PATH does not contain /sbin. * tests/cp/cp-a-selinux: Don't redirect stderr to /dev/null. "mkfs" was failing due to /sbin not being in PATH.
-rw-r--r--README2
-rwxr-xr-xtests/cp/cp-a-selinux2
2 files changed, 2 insertions, 2 deletions
diff --git a/README b/README
index 7a608f41c..7c1883d48 100644
--- a/README
+++ b/README
@@ -145,7 +145,7 @@ I find that it is best to unpack and build as a non-privileged
user, and then to run the following command as that user in order
to run the privilege-requiring tests:
- sudo env NON_ROOT_USERNAME=$USER make -k check-root
+ sudo env PATH="$PATH" NON_ROOT_USERNAME=$USER make -k check-root
If you can run the tests as root, please do so and report any
problems. We get much less test coverage in that mode, and it's
diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux
index 8f854bd0c..dfbded1d2 100755
--- a/tests/cp/cp-a-selinux
+++ b/tests/cp/cp-a-selinux
@@ -34,7 +34,7 @@ cleanup_() { cd /; umount "$cwd/mnt"; }
dd if=/dev/zero of=blob bs=8192 count=200 > /dev/null 2>&1 \
|| framework_failure
mkdir mnt || framework_failure
-mkfs -t ext2 -F blob > /dev/null 2>&1 || framework_failure
+mkfs -t ext2 -F blob || framework_failure
# This context is special: it works even when mcstransd isn't running.
ctx=root:object_r:tmp_t:s0