diff options
author | Jim Meyering <jim@meyering.net> | 2000-12-02 08:19:21 +0000 |
---|---|---|
committer | Jim Meyering <jim@meyering.net> | 2000-12-02 08:19:21 +0000 |
commit | acca4638b8c6956320520da77e54efcc64120740 (patch) | |
tree | 61e3383fb32ca0845c366b00507c84951b807136 | |
parent | 05aabec021d2a11a1f0508a1084eb68d7154a5e0 (diff) | |
download | coreutils-acca4638b8c6956320520da77e54efcc64120740.tar.xz |
(skip, dd_copy): Use ssize_t to store result of
safe_read, to avoid overflow e.g. on 64-bit Solaris sparc.
(dd_copy): Remove unnecessary cast.
-rw-r--r-- | src/dd.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -775,7 +775,7 @@ skip (int fdesc, char *file, uintmax_t records, size_t blocksize, { while (records--) { - int nread = safe_read (fdesc, buf, blocksize); + ssize_t nread = safe_read (fdesc, buf, blocksize); if (nread < 0) { error (0, errno, _("reading %s"), quote (file)); @@ -892,7 +892,7 @@ dd_copy (void) unsigned char *ibuf, *bufstart; /* Input buffer. */ unsigned char *real_buf; /* real buffer address before alignment */ unsigned char *real_obuf; - int nread; /* Bytes read in the current block. */ + ssize_t nread; /* Bytes read in the current block. */ int exit_status = 0; size_t page_size = getpagesize (); size_t n_bytes_read; @@ -991,7 +991,7 @@ dd_copy (void) } } - n_bytes_read = (size_t) nread; + n_bytes_read = nread; if (n_bytes_read < input_blocksize) { |