diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-09-02 21:55:08 +0200 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2012-09-05 08:48:28 +0200 |
| commit | 85d0a65ffb86a732b88221eb5a85ac3169f2cddd (patch) | |
| tree | eb32ce2679643a8f8dcaf9ab865c64ea4d918206 | |
| parent | e8f9c131baf50f094228d2181c5ac83e6182be5a (diff) | |
| download | coreutils-85d0a65ffb86a732b88221eb5a85ac3169f2cddd.tar.xz | |
tests: remove the unused 'root-hint' target
* tests/Makefile.am (root-hint): Here. The interested user can see
the reasons why some tests are skipped by looking at the messages
they display on the console; here's an excerpt:
...
PASS: misc/id-groups.sh
id-setgid.sh: skipped test: must be run as root
SKIP: misc/id-setgid.sh
PASS: misc/md5sum.pl
...
PASS: df/total-verify.sh
2g.sh: skipped test: very expensive: disabled by default
SKIP: du/2g.sh
...
Clear enough, and more specific and precise that a generic "some tests
might need to be run as root" message. And if that user is interested
in making those tests run anyway, he'll just take a look to the README
files to look for info. So there's no reason to pollute the stdout
with another "hint" that is subsumed by those messages, and that might
go unnoticed anyway.
Moreover, and possibly more importantly, that hint wasn't being
displayed anyway, even before this change! That's because the
'root-hint' target was listed as prerequisite for the 'check-recursive'
target, which however was not a dependency of the 'check' target in
'tests/Makefile.am', because that file contains no $(SUBDIRS)
definition.
| -rw-r--r-- | tests/Makefile.am | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/tests/Makefile.am b/tests/Makefile.am index 68ea6b49b..2ef2f10fa 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -162,16 +162,6 @@ all_root_tests = \ check-root: $(MAKE) check TESTS='$(root_tests)' -check-recursive: root-hint - -# Advertise 'check-root' target. -.PHONY: root-hint -root-hint: - @echo '***********************************************************' - @echo "NOTICE: Some tests may be run only as root." - @echo " See the 'Running tests as root' section in README." - @echo '***********************************************************' - EXTRA_DIST += $(all_tests) # Do not choose a name that is a shell keyword like 'if', or a |