diff options
| author | Pádraig Brady <P@draigBrady.com> | 2015-03-20 01:13:17 +0000 |
|---|---|---|
| committer | Pádraig Brady <P@draigBrady.com> | 2015-03-20 01:16:06 +0000 |
| commit | 79e27fd67ed2c23b9cf01c42e3dae741559eb03c (patch) | |
| tree | 41a273724b9d4693577de9d79556cba99480a216 | |
| parent | 1025243b6a0c8b8830b2d3676a97dae83c74d284 (diff) | |
| download | coreutils-79e27fd67ed2c23b9cf01c42e3dae741559eb03c.tar.xz | |
maint: fix wildcard quoting in sc_tests_executable
* cfg.mk (sc_tests_executable): If there are files with
$TEST_EXTENSIONS in the current directory, then the
lack of quoting of the $test_extensions_rx contents
could result in globbing and an inconsequential run.
find(1) produces warnings only with more than one expansion.
| -rw-r--r-- | cfg.mk | 7 |
1 files changed, 3 insertions, 4 deletions
@@ -116,10 +116,9 @@ sc_tests_list_consistency: # Ensure that all version-controlled test scripts are executable. sc_tests_executable: - @test_extensions_rx=`echo $(TEST_EXTENSIONS) \ - | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \ - find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \ - | sed -e "s/^/$(ME): Please make test executable: /" | grep . \ + @test_extensions_rx=`printf -- "-name '*%s' " $(TEST_EXTENSIONS)`;\ + find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \ + | sed -e "s/^/$(ME): Please make test executable: /" | grep . \ && exit 1; : # Ensure all gnulib patches apply cleanly |