summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2009-08-20 10:36:30 +0200
committerJim Meyering <meyering@redhat.com>2009-08-20 10:46:22 +0200
commit3db7c2c03c4c6daf358925d1c585fcbb478fa25a (patch)
tree5215e77ae90374d9cf0318b53e64670170b74c2e
parenta70ac4ef3236afdd1e23e30c1094a2c3557d7c70 (diff)
downloadcoreutils-3db7c2c03c4c6daf358925d1c585fcbb478fa25a.tar.xz
install: avoid a portability bug when compiling with non-gcc
* src/install.c (extra_mode): Be careful to return only a 0 or 1 value, since this is a "bool" function, and there are still some compilers for which this is necessary. Without this change, Bernhard Voelker reported that the Forte Developer 7 C 5.4 2002/03/09 compiler would produce a malfunctioning "install" binary. Details in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/17710/focus=17760
-rw-r--r--src/install.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/install.c b/src/install.c
index 73b3981ef..19efb1d1b 100644
--- a/src/install.c
+++ b/src/install.c
@@ -189,7 +189,7 @@ static bool
extra_mode (mode_t input)
{
const mode_t mask = ~S_IRWXUGO & ~S_IFMT;
- return input & mask;
+ return !! (input & mask);
}
/* Return true if copy of file SRC_NAME to file DEST_NAME is necessary. */