summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPádraig Brady <P@draigBrady.com>2012-12-20 00:09:15 +0000
committerPádraig Brady <P@draigBrady.com>2012-12-21 15:57:25 +0000
commitdd44ccef0da458b682bcb6b866aac1460a5b50a1 (patch)
treee015fe3db6605254a79e16482e28a68859d0fc92
parent8220a17c93c8546b409587f0f6215337b498722d (diff)
downloadcoreutils-dd44ccef0da458b682bcb6b866aac1460a5b50a1.tar.xz
tests: avoid false positive valgrind failures
* init.cfg (require_valgrind_): Check the `true` program, which will check more valgrind failure cases as now detailed in the function comments.
-rw-r--r--init.cfg8
1 files changed, 6 insertions, 2 deletions
diff --git a/init.cfg b/init.cfg
index e853b0a2f..ce5a106de 100644
--- a/init.cfg
+++ b/init.cfg
@@ -159,10 +159,14 @@ require_strace_()
fi
}
-# Skip the current test if valgrind doesn't work.
+# Skip the current test if valgrind doesn't work,
+# which could happen if not installed,
+# or hasn't support for the built architecture,
+# or hasn't appropriate error suppressions installed etc.
require_valgrind_()
{
- valgrind --help >/dev/null || skip_ "requires valgrind"
+ valgrind --error-exitcode=1 true 2>/dev/null ||
+ skip_ "requires a working valgrind"
}
require_setfacl_()