summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefano Lattarini <stefano.lattarini@gmail.com>2013-02-15 14:39:39 +0100
committerPádraig Brady <P@draigBrady.com>2013-02-18 01:27:47 +0000
commitbf7b0e0358bc79141abdd4d974270fbc6bfcba27 (patch)
treee81f717d9ff867937bb752fa76ee40df11ad8a98
parentc53c5e2395d206a1ab2c821eed8414270fbc07b4 (diff)
downloadcoreutils-bf7b0e0358bc79141abdd4d974270fbc6bfcba27.tar.xz
maint: don't reset PATH in the commit-msg git hook
I have a custom 'editor' script in ~/bin, and a system-provided 'editor' program in /usr/bin (on Debian, this is a link set up the "debian alternatives" subsystem). My '$EDITOR' and '$GIT_EDITOR' variables are set simply to 'editor' (no absolute path), which I expect should point to my 'editor' script, since ~/bin precedes /usr/bin in my PATH definition. But the 'commit-msg' hook used in coreutils unconditionally resets its PATH to '/bin:/usr/bin', which causes it to call the "wrong" editor (the one in /usr/bin, not the one in ~/bin) when it makes me update a botched commit message. * scripts/git-hooks: Don't reset $ENV{PATH} to '/bin:/usr/bin', which was only done to avoid failure when enabling Perl's taint checking.
-rwxr-xr-xscripts/git-hooks/commit-msg1
1 files changed, 0 insertions, 1 deletions
diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
index 3e91e8ea4..7a1148949 100755
--- a/scripts/git-hooks/commit-msg
+++ b/scripts/git-hooks/commit-msg
@@ -7,7 +7,6 @@ use warnings;
(my $ME = $0) =~ s|.*/||;
my $editor = $ENV{EDITOR} || 'vi';
-$ENV{PATH} = '/bin:/usr/bin';
# Keywords allowed before the colon on the first line of a commit message:
# program names and a few general category names.