From ac3618ca9d4d5136b8e231c6de23b2da6add204f Mon Sep 17 00:00:00 2001 From: Eduardo Chappa Date: Mon, 29 Jun 2020 00:54:43 -0600 Subject: * URLs that are surrounded by white space are not cleaned by Alpine before passing them to the browser, resulting in no display of the URL when Alpine tries to open it. Reported by Gregory Heytings. --- pith/filter.c | 2 ++ pith/pine.hlp | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/pith/filter.c b/pith/filter.c index 0c2f5256..8e7c92ee 100644 --- a/pith/filter.c +++ b/pith/filter.c @@ -5028,6 +5028,8 @@ html_a(HANDLER_S *hd, int ch, int cmd) * we were giving some "base" string, proceed ala RFC1808... */ if(href){ + if(href->value) + removing_leading_and_trailing_white_space(href->value); if(HTML_BASE(hd->html_data) && !rfc1738_scan(href->value, &n)){ html_a_relative(HTML_BASE(hd->html_data), href->value, h); } diff --git a/pith/pine.hlp b/pith/pine.hlp index a005fc64..92f2d9a3 100644 --- a/pith/pine.hlp +++ b/pith/pine.hlp @@ -140,7 +140,7 @@ with help text for the config screen and the composer that didn't have any reasonable place to be called from. Dummy change to get revision in pine.hlp ============= h_revision ================= -Alpine Commit 469 2020-06-28 23:10:19 +Alpine Commit 470 2020-06-29 00:41:56 ============= h_news ================= @@ -233,6 +233,10 @@ Bugs addressed:
  • When an attachment is deleted and the original message is saved, Alpine might write only a part of the name of the file deleted. Reported by Holger Trapp. + +
  • URLs that are surrounded by white space are not cleaned by Alpine before + passing them to the browser, resulting in no display of the URL when Alpine + tries to open it. Reported by Gregory Heytings.

    -- cgit v1.2.3-70-g09d2