From 3d7933462d3e0017052cf23168e946453aa7bc4e Mon Sep 17 00:00:00 2001 From: Eduardo Chappa Date: Wed, 5 Aug 2020 18:43:29 -0600 Subject: * Crash when Alpine frees memory on a system where LC_CTYPE is not configured, and the user calls the file browser to attach files to a message. Reported by Luis Gerardo Tejero. --- pith/charconv/utf8.c | 2 +- pith/pine.hlp | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/pith/charconv/utf8.c b/pith/charconv/utf8.c index 2bb301c7..e1f16b3f 100644 --- a/pith/charconv/utf8.c +++ b/pith/charconv/utf8.c @@ -283,7 +283,7 @@ convert_to_utf8(char *str, char *fromcharset, int flags) } /* else no conversion necessary */ - if(result.data) + if(result.data && result.data != src.data) fs_give((void **) &result.data); result.size = 0; diff --git a/pith/pine.hlp b/pith/pine.hlp index 9177d488..48c1a4bd 100644 --- a/pith/pine.hlp +++ b/pith/pine.hlp @@ -140,7 +140,7 @@ with help text for the config screen and the composer that didn't have any reasonable place to be called from. Dummy change to get revision in pine.hlp ============= h_revision ================= -Alpine Commit 499 2020-08-05 03:09:13 +Alpine Commit 500 2020-08-05 18:43:02 ============= h_news ================= @@ -261,6 +261,10 @@ Bugs addressed:
  • When Alpine opens a folder in a server whose address is given numerically it might crash due to an incorrect freeing of memory. Reported by Wang Kang. +
  • Crash when Alpine frees memory on a system where LC_CTYPE is not + configured, and the user calls the file browser to attach files to + a message. Reported by Luis Gerardo Tejero. +
  • Invalid signatures created by Alpine, when built with recent releases of the Openssl-1.1.1 series (but not in the Openssl-1.0.1 series). Fix contributed by Bernd Edlinger. -- cgit v1.2.3-54-g00ecf