summaryrefslogtreecommitdiff
path: root/alpine/help.c
diff options
context:
space:
mode:
authorEduardo Chappa <chappa@washington.edu>2014-02-02 00:18:35 -0700
committerEduardo Chappa <chappa@washington.edu>2014-02-02 00:18:35 -0700
commit18a5af00c1cf15852d694d20c58e7271112263d8 (patch)
tree5b46b810260e0161cb3c9eac5e04d80712651b84 /alpine/help.c
parent1bf084e1ed4cd931b08e233a3f5c30cc9de05dfc (diff)
downloadalpine-18a5af00c1cf15852d694d20c58e7271112263d8.tar.xz
* Update to version 2.19.5
* check bounds and tie strings off to improve security. Contributed by James Jerkins. * Alpine crashed when a user attempted to add a folder collection, due to bug in GET_NAMESPACE in imap4r1.c.
Diffstat (limited to 'alpine/help.c')
-rw-r--r--alpine/help.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/alpine/help.c b/alpine/help.c
index b291defd..0fe06b43 100644
--- a/alpine/help.c
+++ b/alpine/help.c
@@ -5,7 +5,7 @@ static char rcsid[] = "$Id: help.c 1032 2008-04-11 00:30:04Z hubert@u.washington
/*
* ========================================================================
* Copyright 2006-2008 University of Washington
- * Copyright 2013 Eduardo Chappa
+ * Copyright 2013-2014 Eduardo Chappa
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -414,7 +414,8 @@ help_processor(int cmd, MSGNO_S *msgmap, SCROLL_S *sparms)
help_name[0] = '\0';
for(t = h_texts; t->help_text != NO_HELP; t++)
if(t->help_text == ((HELP_SCROLL_S *)sparms->proc.data.p)->help_source){
- strcpy(help_name,t->tag);
+ strncpy(help_name, t->tag, sizeof(help_name)-1);
+ help_name[sizeof(help_name)-1] = '\0';
break;
}
if(help_name[0])