diff options
author | Eduardo Chappa <chappa@washington.edu> | 2016-07-28 16:34:13 -0600 |
---|---|---|
committer | Eduardo Chappa <chappa@washington.edu> | 2016-07-28 16:34:13 -0600 |
commit | 72f1f0e3de5c91874572cf530bf5f2d35ba2ba5f (patch) | |
tree | 0e9b3fe49103dc635a60e37fef52464af3a7d942 | |
parent | bacff96fec05079560b7d7a9fc48b6811b639499 (diff) | |
download | alpine-72f1f0e3de5c91874572cf530bf5f2d35ba2ba5f.tar.xz |
* Bug: Alpine would use freed memory while trying to compute the color
of the titlebar. This happened when trying to continue a postponed
message. Alpine would call the format_titlebar function, which would
attempt to use the msgmap of the freed stream of the postponed
messages folder. The solution was to not to call the format_titlebar
function, because all that is needed is the color of the titlebar,
and that can be obtained in a different way.
-rw-r--r-- | alpine/titlebar.c | 4 | ||||
-rw-r--r-- | pith/pine.hlp | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/alpine/titlebar.c b/alpine/titlebar.c index fa825be9..7b30827c 100644 --- a/alpine/titlebar.c +++ b/alpine/titlebar.c @@ -379,12 +379,10 @@ titlebar_stream_closing(MAILSTREAM *stream) COLOR_PAIR * current_titlebar_color(void) { - TITLE_S *tc; COLOR_PAIR *col; COLOR_PAIR *the_color = NULL; - tc = format_titlebar(); - col = tc ? &tc->color : NULL; + col = as.title ? &as.titlecontainer.color : NULL; if(col && col->fg && col->fg[0] && col->bg && col->bg[0]) the_color = new_color_pair(col->fg, col->bg); diff --git a/pith/pine.hlp b/pith/pine.hlp index 4c72e2a4..a1950964 100644 --- a/pith/pine.hlp +++ b/pith/pine.hlp @@ -376,6 +376,10 @@ Bugs that have been addressed include: of the certificate to lowercase, which may make Alpine not be able to read such certificate. Reported by Dennis Davis. + <LI> Alpine would use freed memory while trying to compute the color + of the titlebar. This happened when trying to continue a postponed + message. + <LI> When selecting messages while in Threaded Index Screen, some messages other than top of threads could appear in the index, making Alpine display messages "out of the screen." |