diff options
| author | Eduardo Chappa <chappa@washington.edu> | 2018-12-20 19:10:36 -0700 |
|---|---|---|
| committer | Eduardo Chappa <chappa@washington.edu> | 2018-12-20 19:10:36 -0700 |
| commit | 08d6d80b7cd3cccb32a81d91c481bbde938f4689 (patch) | |
| tree | 61698e096c05e3d5c71787cb55310f6b9ccc30fc | |
| parent | 8602b838267f8853a00438a70bf5fdf3ddb24319 (diff) | |
| download | alpine-08d6d80b7cd3cccb32a81d91c481bbde938f4689.tar.xz | |
* When a message/rfc822 part of a message is encoded with
Content-Transfer-Encoding: QUOTED-PRINTABLE, Alpine will stop
processing that message. Later this causes Alpine to crash because
when it displays messages, it assumes that both header and body parts
are processed. Reported by Mark Crispin in 2010, in the Alpine-info
list (message with subject "crash bug in
alpine/mailpart.c:format_msg_att()") with no example, and reported
now by Holger Trapp, with an example.
| -rw-r--r-- | alpine/mailpart.c | 15 | ||||
| -rw-r--r-- | pith/pine.hlp | 9 |
2 files changed, 21 insertions, 3 deletions
diff --git a/alpine/mailpart.c b/alpine/mailpart.c index 061ca5e2..74f84adb 100644 --- a/alpine/mailpart.c +++ b/alpine/mailpart.c @@ -2724,7 +2724,10 @@ format_msg_att(long int msgno, ATTACH_S **a, HANDLE_S **handlesp, gf_io_t pc, in gf_puts(NEWLINE, pc); - ++(*a); + if(((*a)+1)->description) + ++(*a); + else + return rv; #ifdef SMIME if((*a)->body && (*a)->body->subtype && (strucmp((*a)->body->subtype, OUR_PKCS7_ENCLOSURE_SUBTYPE)==0)){ @@ -2736,7 +2739,10 @@ format_msg_att(long int msgno, ATTACH_S **a, HANDLE_S **handlesp, gf_io_t pc, in rv = 0; } - ++(*a); + if(((*a)+1)->description) + ++(*a); + else + return rv; } #endif /* SMIME */ @@ -2752,7 +2758,10 @@ format_msg_att(long int msgno, ATTACH_S **a, HANDLE_S **handlesp, gf_io_t pc, in && gf_puts(NEWLINE, pc))) rv = 0; - ++(*a); + if(((*a)+1)->description) + ++(*a); + else + return rv; } else if((*a)->body->subtype diff --git a/pith/pine.hlp b/pith/pine.hlp index 1b6afe20..6d8b40b4 100644 --- a/pith/pine.hlp +++ b/pith/pine.hlp @@ -253,6 +253,15 @@ Bugs that have been addressed include: and sent that way even when the option Do Not Send Flowed Text is enabled. Reported by Holger Trapp. + <LI> When a message/rfc822 part of a message is encoded with + Content-Transfer-Encoding: QUOTED-PRINTABLE, Alpine will stop + processing that message. Later this causes Alpine to crash because + when it displays messages, it assumes that both header and body + parts are processed. Reported by Mark Crispin in 2010, in the + Alpine-info list (message with subject "crash bug in + alpine/mailpart.c:format_msg_att()") with no example, and reported + now by Holger Trapp, with an example. + <LI> Update build.bat file to add /DWINVER=0x0501 so that Alpine can build when using Visual Studio 2017. Fix contributed by Ulf-Dietrich Braunmann. |